Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use cloudflare/wrangler-action in deploy #795

Merged
merged 4 commits into from
Feb 11, 2025
Merged

Conversation

marcustyphoon
Copy link
Collaborator

@marcustyphoon marcustyphoon commented Sep 14, 2024

cloudflare/pages-action appears to be abandoned (without a note in the readme! I am not impressed by the state of your tooling, cloudflare!), so I think we'll eventually have to do this. cloudflare/wrangler-action currently does not create github deployments, to my knowledge, however, so I'm happy to wait.

See cloudflare/pages-action#117 and cloudflare/wrangler-action#274.

  • check if there are new/different action outputs to improve the PR comment

[draft previews]

@marcustyphoon marcustyphoon force-pushed the wrangler-action branch 2 times, most recently from d1c2651 to 36bceb3 Compare November 27, 2024 20:48
@marcustyphoon
Copy link
Collaborator Author

marcustyphoon commented Nov 27, 2024

cloudflare/wrangler-action#325 was shipped but I'm not sure it... worked? I see no action summary from this PR. Anyway, it noted more improvements to come in the future, which included changing the preference API again, so may as well wait for that.

@marcustyphoon marcustyphoon changed the title Chore: Use cloudflare/wrangler-action in deploy chore: Use cloudflare/wrangler-action in deploy Nov 27, 2024
@marcustyphoon
Copy link
Collaborator Author

Nice: seems to be working now. Could merge this or leave it around until cloudflare/wrangler-action#333.

Copy link
Contributor

github-actions bot commented Feb 11, 2025

Deployed build to Cloudflare!

Last commit: e7282f1
Preview URL: https://6b066691.discretize-gear-optimizer.pages.dev
Branch Preview URL: https://wrangler-action.discretize-gear-optimizer.pages.dev

@marcustyphoon marcustyphoon marked this pull request as ready for review February 11, 2025 01:03
@marcustyphoon marcustyphoon merged commit 96e2786 into main Feb 11, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant