Use CrtrExpLevel typedef for most level-related stuff #3820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walt253
commented
Jan 11, 2025
| {PwrK_None, GA_None, 0, 0, 0, 0}, | ||
| }; | ||
| ^->According to this 'caspl->pwlevel' is either 0, 1, 2 or 8. | ||
| } */ |
There was a problem hiding this comment.
I will clean this up later but let me know what you think about it.
There was a problem hiding this comment.
I will clean this up later but let me know what you think about it.
There was a problem hiding this comment.
Repeat num is how often they cast the same spell right? Or what is the feedback you want here?
walt253
commented
Jan 11, 2025
| @@ -618,20 +618,18 @@ TbBool create_task_slap_imps(struct Computer2 *comp, long creatrs_num); | |||
| TbBool create_task_dig_to_neutral(struct Computer2 *comp, const struct Coord3d startpos, const struct Coord3d endpos); | |||
| TbBool create_task_dig_to_gold(struct Computer2 *comp, const struct Coord3d startpos, const struct Coord3d endpos, long parent_cproc_idx, long count_slabs_to_dig, long gold_lookup_idx); | |||
| TbBool create_task_dig_to_entrance(struct Computer2 *comp, const struct Coord3d startpos, const struct Coord3d endpos, long parent_cproc_idx, long entroom_idx); | |||
| TbBool create_task_magic_speed_up(struct Computer2 *comp, const struct Thing *creatng, long splevel); | |||
| TbBool create_task_magic_flight_up(struct Computer2 *comp, const struct Thing *creatng, long splevel); | |||
| TbBool create_task_magic_vision_up(struct Computer2 *comp, const struct Thing *creatng, long splevel); | |||
There was a problem hiding this comment.
create_task_magic_flight_up & create_task_magic_vision_up are not used anymore.
walt253
commented
Jan 11, 2025
| if (exp >= CREATURE_MAX_LEVEL) | ||
| exp = 0; |
There was a problem hiding this comment.
I believe this was a mistake and should be exp = CREATURE_MAX_LEVEL but let me know if it's not.
Loobinex
reviewed
Jan 20, 2025
| @@ -116,7 +116,7 @@ Comp_Event_Func computer_event_func_list[] = { | |||
| NULL, | |||
| }; | |||
|
|
|||
| //PowerKind pwkind; char gaction; char require_owned_ground; int repeat_num; int pwlevel; int amount_able; | |||
| //PowerKind pwkind; char gaction; char require_owned_ground; int repeat_num; CrtrExpLevel pwlevel; int amount_able; | |||
There was a problem hiding this comment.
Is this right? Powers can accept a level less than creatures right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.