Fix for the issue #79: Closure Compiler Error with ES6 code and Dojo 1.16.0 #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgraded the Google Closure Compiler to v20200112
The format of a Google Closure Compiler error has changed (see https://github.com/google/closure-compiler/blob/35beaa864997442d635875add4d60b7b73be6294/src/com/google/javascript/jscomp/LightweightMessageFormatter.java#L113-L116)
The API accessing the Closure Executor Service has changed in this commit: google/closure-compiler@7bdbe96
1. Assume the Google Closure Compiler's input as non-strict-mode JavaScript 2. Do not emit "use strict"; in the transpiled output 3. Force reporting DiagnosticGroups.ES5_STRICT issues as warnings, instead of errors
|
Hello @dylans, any chance to merge the PR? Thank you in advance! |
dylans
approved these changes
Jan 30, 2020
|
@dylans, thank you a lot for approving the PR! How does that go now, someone should merge the PR into the master? Thank you! |
|
Hello @dylans, any chance to merge the PR, after you have already approved it? Thank you in advance! |
|
There's been three new releases since this PR was created: https://github.com/google/closure-compiler/wiki/Releases We're also looking forward to this upgrade. |
|
Apologies, don't know why I kept missing this one... will merge it now and include it in the next release. |
dylans
pushed a commit
that referenced
this pull request
Jun 8, 2020
…1.16.0 (#80) * Upgraded Closure Compiler Upgraded the Google Closure Compiler to v20200112 * Fixed a typo * New format of Closure Compiler errors The format of a Google Closure Compiler error has changed (see https://github.com/google/closure-compiler/blob/35beaa864997442d635875add4d60b7b73be6294/src/com/google/javascript/jscomp/LightweightMessageFormatter.java#L113-L116) * Fixed shutting Closure Executor Service down The API accessing the Closure Executor Service has changed in this commit: google/closure-compiler@7bdbe96 * Allow compiling dojo's non-strict-mode code 1. Assume the Google Closure Compiler's input as non-strict-mode JavaScript 2. Do not emit "use strict"; in the transpiled output 3. Force reporting DiagnosticGroups.ES5_STRICT issues as warnings, instead of errors (cherry picked from commit 86f0042)
dylans
pushed a commit
that referenced
this pull request
Jun 8, 2020
…1.16.0 (#80) * Upgraded Closure Compiler Upgraded the Google Closure Compiler to v20200112 * Fixed a typo * New format of Closure Compiler errors The format of a Google Closure Compiler error has changed (see https://github.com/google/closure-compiler/blob/35beaa864997442d635875add4d60b7b73be6294/src/com/google/javascript/jscomp/LightweightMessageFormatter.java#L113-L116) * Fixed shutting Closure Executor Service down The API accessing the Closure Executor Service has changed in this commit: google/closure-compiler@7bdbe96 * Allow compiling dojo's non-strict-mode code 1. Assume the Google Closure Compiler's input as non-strict-mode JavaScript 2. Do not emit "use strict"; in the transpiled output 3. Force reporting DiagnosticGroups.ES5_STRICT issues as warnings, instead of errors (cherry picked from commit 86f0042)
dylans
pushed a commit
that referenced
this pull request
Jun 8, 2020
…1.16.0 (#80) * Upgraded Closure Compiler Upgraded the Google Closure Compiler to v20200112 * Fixed a typo * New format of Closure Compiler errors The format of a Google Closure Compiler error has changed (see https://github.com/google/closure-compiler/blob/35beaa864997442d635875add4d60b7b73be6294/src/com/google/javascript/jscomp/LightweightMessageFormatter.java#L113-L116) * Fixed shutting Closure Executor Service down The API accessing the Closure Executor Service has changed in this commit: google/closure-compiler@7bdbe96 * Allow compiling dojo's non-strict-mode code 1. Assume the Google Closure Compiler's input as non-strict-mode JavaScript 2. Do not emit "use strict"; in the transpiled output 3. Force reporting DiagnosticGroups.ES5_STRICT issues as warnings, instead of errors (cherry picked from commit 86f0042)
dylans
pushed a commit
that referenced
this pull request
Jun 8, 2020
…1.16.0 (#80) * Upgraded Closure Compiler Upgraded the Google Closure Compiler to v20200112 * Fixed a typo * New format of Closure Compiler errors The format of a Google Closure Compiler error has changed (see https://github.com/google/closure-compiler/blob/35beaa864997442d635875add4d60b7b73be6294/src/com/google/javascript/jscomp/LightweightMessageFormatter.java#L113-L116) * Fixed shutting Closure Executor Service down The API accessing the Closure Executor Service has changed in this commit: google/closure-compiler@7bdbe96 * Allow compiling dojo's non-strict-mode code 1. Assume the Google Closure Compiler's input as non-strict-mode JavaScript 2. Do not emit "use strict"; in the transpiled output 3. Force reporting DiagnosticGroups.ES5_STRICT issues as warnings, instead of errors (cherry picked from commit 86f0042)
dylans
pushed a commit
that referenced
this pull request
Jun 8, 2020
…1.16.0 (#80) * Upgraded Closure Compiler Upgraded the Google Closure Compiler to v20200112 * Fixed a typo * New format of Closure Compiler errors The format of a Google Closure Compiler error has changed (see https://github.com/google/closure-compiler/blob/35beaa864997442d635875add4d60b7b73be6294/src/com/google/javascript/jscomp/LightweightMessageFormatter.java#L113-L116) * Fixed shutting Closure Executor Service down The API accessing the Closure Executor Service has changed in this commit: google/closure-compiler@7bdbe96 * Allow compiling dojo's non-strict-mode code 1. Assume the Google Closure Compiler's input as non-strict-mode JavaScript 2. Do not emit "use strict"; in the transpiled output 3. Force reporting DiagnosticGroups.ES5_STRICT issues as warnings, instead of errors (cherry picked from commit 86f0042)
|
Thank you, @dylans! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull request presents a fix for the issue #79.
This upgrades the Google Closure Compiler to v20200112, the latest one at the time of the pull request submittal.
This also tweaks the dojo's build system to instruct the Google Closure Compiler compile non-strict-mode JavaScript code.