InputCommon: Fix input expression assignment operator behavior. #13314
+113
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordan-woyak
force-pushed
the
input-expressions-assignment-op-fix
branch
from
bd4b2bd to
6a05d31
Compare
jordan-woyak
changed the title
jordan-woyak
force-pushed
the
input-expressions-assignment-op-fix
branch
from
6a05d31 to
c9ad543
Compare
dreamsyntax
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assignment-operator was always broken when interacting with comma-operator and other assignment-operators.
Before:
All of these should evaluate as 1.
After:
All the above now evaluate as 1 as they should.
LHS is evaluated before RHS (consistent for all binary operators).
Conditional operator produces an l-value.
Making
Expression::GetValuenon-const eliminated a bunch of uglymutableusage.