Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(TimeMachine) Permissionable shortLivedKey was bad + Skip Velocity cache when time-machine is set #31222

Merged
merged 9 commits into from
Jan 29, 2025
Merged

fix(TimeMachine) Permissionable shortLivedKey was bad + Skip Velocity cache when time-machine is set #31222

merged 9 commits into from
Jan 29, 2025

Conversation

fabrizzio-dotCMS
Copy link
Contributor

@fabrizzio-dotCMS fabrizzio-dotCMS commented Jan 24, 2025 •
edited by github-actions bot
Loading

Proposed Changes

  • I'm changing the shortLivedKey used to cache permissions for Contentlets, the problem we want to fix here is that in the permissions cache, we can have an identifier saying that a user did not have permissions on a working and live version, while the user, in reality, had permissions on the live version.
  • Ultimately, I introduced a change to skip caching the velocity templates when the future time machine runs. This is a cleaner fix for the problem of unmatching content shown in both sides, the rendered portion and the headless pieces.

This PR fixes: #30991

@github-actions github-actions bot mentioned this pull request Jan 24, 2025
Closed
@fabrizzio-dotCMS fabrizzio-dotCMS changed the title fix(TimeMachine) Permissionable hash was bad for content Refs: fix(TimeMachine) Permissionable shortLivedKey was bad + Skip Velocity cache when time-machine is set Jan 26, 2025
@fabrizzio-dotCMS fabrizzio-dotCMS marked this pull request as ready for review January 26, 2025 16:50
@fabrizzio-dotCMS fabrizzio-dotCMS linked an issue Jan 28, 2025 that may be closed by this pull request
UVE: 🐛 Prevent Read-Only Token Access to Working Content #30991
Closed
@fabrizzio-dotCMS fabrizzio-dotCMS added this pull request to the merge queue Jan 29, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 29, 2025
@fabrizzio-dotCMS fabrizzio-dotCMS added this pull request to the merge queue Jan 29, 2025
Merged via the queue into main with commit 4e5e552 Jan 29, 2025
36 checks passed
@fabrizzio-dotCMS fabrizzio-dotCMS deleted the issue-30991-read-only-token-working-content branch January 29, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdotcms jdotcms jdotcms left review comments

@nollymar nollymar nollymar approved these changes

@valentinogiardino valentinogiardino valentinogiardino approved these changes

@freddyDOTCMS freddyDOTCMS Awaiting requested review from freddyDOTCMS

@wezell wezell Awaiting requested review from wezell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UVE: 🐛 Prevent Read-Only Token Access to Working Content
4 participants
@fabrizzio-dotCMS @nollymar @jdotcms @valentinogiardino