chore(edit-content): include language field for search in relationships field #31253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicobytes
changed the title
oidacra
reviewed
Jan 28, 2025
...ect-existing-content/components/search/components/language-field/language-field.component.ts
Show resolved
Hide resolved
oidacra
reviewed
Jan 28, 2025
...ionship-field/components/dot-select-existing-content/components/search/search.compoment.html
Show resolved
Hide resolved
oidacra
approved these changes
Jan 28, 2025
…h' of github.com:dotCMS/core into 31127-relationship-field-enable-static-fields-for-search
hmoreras
approved these changes
Jan 29, 2025
nicobytes
deleted the
31127-relationship-field-enable-static-fields-for-search
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent Issue
#31127
Proposed Changes
This pull request introduces a new
LanguageFieldComponentfor selecting languages in a dropdown menu. It includes the component's implementation, its associated store for managing state, and comprehensive unit tests for both the component and the store.New Component and Store Implementation:
Component Implementation:
language-field.component.html: Added HTML template for the language dropdown, including labels, dropdown options, and error handling.language-field.component.ts: Defined theLanguageFieldComponentwith Angular'sControlValueAccessorandOnInitinterfaces, including methods for handling language selection and form control integration.Store Implementation:
language-field.store.ts: CreatedLanguageFieldStoreusing NgRx signals for state management, including methods for loading languages, selecting a language, and handling errors.Unit Tests:
Component Tests:
language-field.component.spec.ts: Added unit tests for theLanguageFieldComponent, covering initialization, value writing, change handling, and edge cases.Store Tests:
language-field.store.spec.ts: Added unit tests for theLanguageFieldStore, covering initial state, state management, language selection, error handling, and reset functionality.Checklist
This PR fixes: #31127