fix(page): Issues switching PageView Refs: #31362 #31386
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please use a Conventional Commit title format for this PR. For more information, see https://www.conventionalcommits.org/en/v1.0.0/ |
fabrizzio-dotCMS
changed the title
|
Please use a Conventional Commit title format for this PR. For more information, see https://www.conventionalcommits.org/en/v1.0.0/ |
…/github.com/dotCMS/core into issue-31362-inconsisten-image-swithing-mode
…/github.com/dotCMS/core into issue-31362-inconsisten-image-swithing-mode
…/github.com/dotCMS/core into issue-31362-inconsisten-image-swithing-mode
zJaaal
changed the title
zJaaal
changed the title
fabrizzio-dotCMS
changed the title
fabrizzio-dotCMS
deleted the
issue-31362-inconsisten-image-swithing-mode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When switching between Draft, Edit, Preview, and Live modes to visualize pages, the current approach relies too heavily on session-scoped variables to determine the Page Mode (e.g., Live or Working). This fragility led to a bug where an unexpected request set an incorrect Page Mode value (such as Navigate or Preview) at the session level, causing the Live view to break. As a result, the Image API could not return the expected image.
Proposed Changes
The Page Mode should not be set at the session level. If the Page Mode can be passed as a variable (such as through the Request), it should be done this way. This Pull Request refactors the handling of Page Mode to avoid a session-based state whenever possible, ensuring more predictable and stable behavior across different rendering modes.