Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ResourceUtilizationInstruments to Shared project #5844

Merged
merged 3 commits into from
Feb 5, 2025
Merged

Move ResourceUtilizationInstruments to Shared project #5844

merged 3 commits into from
Feb 5, 2025

Conversation

amadeuszl
Copy link
Contributor

@amadeuszl amadeuszl commented Feb 4, 2025 •
edited by dotnet-policy-service bot
Loading

Fixes #5813

Microsoft Reviewers: Open in CodeFlow

@amadeuszl amadeuszl requested review from a team as code owners February 4, 2025 13:39
@dotnet-comment-bot
Copy link
Collaborator

‼️ Found issues ‼️

Project Coverage Type Expected Actual
Microsoft.Extensions.Caching.Hybrid Line 86 77.82 🔻
Microsoft.Extensions.AI.Ollama Line 80 78.25 🔻
Microsoft.Gen.MetadataExtractor Line 98 57.35 🔻
Microsoft.Gen.MetadataExtractor Branch 98 62.5 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.AI.OpenAI 77 78
Microsoft.Extensions.AI 88 89
Microsoft.Extensions.AI.Abstractions 83 84

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=939691&view=codecoverage-tab

@amadeuszl amadeuszl merged commit bab8a9b into dotnet:main Feb 5, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RussKie RussKie RussKie approved these changes

@eduherminio eduherminio eduherminio approved these changes

@evgenyfedorov2 evgenyfedorov2 evgenyfedorov2 approved these changes

Assignees

@amadeuszl amadeuszl

Labels
area-resourcemonitoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move ResourceUtilizationInstruments constants to Shared project
5 participants
@amadeuszl @dotnet-comment-bot @RussKie @eduherminio @evgenyfedorov2