Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WASI] add trailing header support to WasiHTTPHandler #109840

Closed
wants to merge 1 commit into from

Conversation

dicej
Copy link
Contributor

@dicej dicej commented Nov 14, 2024

No description provided.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Nov 14, 2024
dicej added a commit to dicej/runtimelab that referenced this pull request Nov 14, 2024
v26.0.1 includes bytecodealliance/wasmtime#9208, which
came up while implementing dotnet/runtime#109840

Signed-off-by: Joel Dice <[email protected]>
jkotas pushed a commit to dotnet/runtimelab that referenced this pull request Nov 14, 2024
v26.0.1 includes bytecodealliance/wasmtime#9208, which
came up while implementing dotnet/runtime#109840

Signed-off-by: Joel Dice <[email protected]>
@maraf maraf added arch-wasm WebAssembly architecture os-wasi Related to WASI variant of arch-wasm labels Nov 15, 2024
@maraf maraf added this to the 10.0.0 milestone Nov 15, 2024
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@pavelsavara
Copy link
Member

Is TE: trailers already supported by wasmtime ? Or we are not blocked by that ?

(My previous PR #107795)

@dicej
Copy link
Contributor Author

dicej commented Nov 18, 2024

Is TE: trailers already supported by wasmtime ? Or we are not blocked by that ?

Yes, good point. I forgot that you need to modify Wasmtime to actually make this work, and also forgot you had opened a PR for this also. I'll close this one too, and we can revisit once the wasi:http spec is clarified with respect to trailers and wasmtime-wasi-http has been updated accordingly.

@dicej dicej closed this Nov 18, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-System.Net.Http community-contribution Indicates that the PR has been added by a community member os-wasi Related to WASI variant of arch-wasm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants