Skip to content

Commit

Permalink
Unskip the checked tests.
Browse files Browse the repository at this point in the history
  • Loading branch information
carlossanlop committed Feb 13, 2025
1 parent 2281983 commit 27200d1
Showing 1 changed file with 4 additions and 8 deletions.
12 changes: 4 additions & 8 deletions test/Microsoft.DotNet.ApiDiff.Tests/Diff.Operators.Tests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -613,8 +613,7 @@ public class MyClass
""");
}

// The checked operator isn't being handled by Roslyn, it's going to be fixed with https://github.com/dotnet/roslyn/pull/77102
[Fact(Skip = "https://github.com/dotnet/roslyn/issues/77101")]
[Fact]
public void TestExplicitCheckedOperator()
{
RunTest(beforeCode: """
Expand All @@ -634,14 +633,14 @@ public class MyClass
public static explicit operator checked byte(MyClass value) => checked((byte)(MyClass)value);
}
}
""",
""", // Notice they get sorted
expectedCode: """
namespace MyNamespace
{
public class MyClass
{
+ public static explicit operator byte(MyClass value) { throw null; }
+ public static explicit operator checked byte(MyClass value) { throw null; }
+ public static explicit operator byte(MyClass value) { throw null; }
}
}
""");
Expand Down Expand Up @@ -725,10 +724,7 @@ public class MyClass
apisToExclude: ["M:MyNamespace.MyClass.op_Explicit(MyNamespace.MyClass)~System.Int32"]);
}

// The checked operator isn't being handled by Roslyn, so even when it's not going to show up in the diff,
// we try to process it but we end up throwing an exception as it is unrecognized.
// It's going to be fixed with https://github.com/dotnet/roslyn/pull/77102
[Fact(Skip = "https://github.com/dotnet/roslyn/issues/77101")]
[Fact]
public void TestExcludeUnmodifiedOperator()
{
RunTest(beforeCode: """
Expand Down

0 comments on commit 27200d1

Please sign in to comment.