[ApiDiff] Allow passing diagnostic options to all Compat places that use CSharpCompilationOptions #46424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
1 similar comment
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
carlossanlop
force-pushed
the
AllowDiagnostic
branch
from
d401120 to
f6d2342
Compare
carlossanlop
force-pushed
the
AllowDiagnostic
branch
from
f6d2342 to
0790969
Compare
…at use CSharpCompilatioOptions in Compat.
carlossanlop
force-pushed
the
AllowDiagnostic
branch
from
0790969 to
7b739f5
Compare
carlossanlop
added
Area-ApiCompat
and removed
untriaged
michaelgsharp
approved these changes
Jan 31, 2025
|
/ba-g Failure is new but unrelated (dotnet watch): #46454 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #46380
This PR is part of the work needed to create an ApiDiff tool that reuses some of the code from Microsoft.DotNet.GenAPI. The idea is to make the larger PR smaller and make it easier to review: #45389
The proposed changes in this PR include: