finishing bulk.wast
#281
Merged
finishing bulk.wast
#281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreaTP
force-pushed
the
finish-bulk.wast
branch
from
a4a63cd to
507ffcc
Compare
andreaTP
force-pushed
the
finish-bulk.wast
branch
from
507ffcc to
13bbd6a
Compare
bhelx
reviewed
Apr 24, 2024
Comment on lines
+1602
to
+1618
| var elementCount = instance.elementCount(); | ||
| var currentElement = instance.element(elementidx); | ||
| var currentElementCount = | ||
| (currentElement instanceof PassiveElement) ? currentElement.elementCount() : 0; | ||
| boolean isOutOfBounds = | ||
| (size < 0 | ||
| || elementidx > elementCount | ||
| || (size > 0 | ||
| && (currentElement == null | ||
| || !(currentElement instanceof PassiveElement))) | ||
| || elemidx + size > currentElementCount | ||
| || end > table.size()); | ||
|
|
||
| if (isOutOfBounds) { | ||
| throw new WASMRuntimeException("out of bounds table access"); | ||
| } else if (size == 0) { | ||
| return; |
There was a problem hiding this comment.
nit: this is a little bit hard to follow and might make sense to break into some variables.
There was a problem hiding this comment.
Agree, that's the best I could come up with ... but I secretly hope that it will be split and moved to other classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finishing the last few
bulk.wastmissing tests.