fix: removed len(properties) > 0 validation in simulation #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhmd-azeez
commented
Dec 17, 2024
| @@ -85,9 +85,6 @@ func validateToolDescription(tool ToolDescription) error { | |||
| if !ok { | |||
| return fmt.Errorf("tool %s: inputSchema.properties must be an object", tool.Name) | |||
| } | |||
There was a problem hiding this comment.
Should we also remove these validations rules?
There was a problem hiding this comment.
if they are not accurate, then yes let's remove them.
There was a problem hiding this comment.
not sure if this going to impact mcpx/mcp.run api cc @chrisdickinson
There was a problem hiding this comment.
If I read the spec correctly the logic is "if properties are present, they must be an object". Otherwise I think we'll be okay from the mcpx/mcp.run perspective!
There was a problem hiding this comment.
@chrisdickinson thanks for the clarification, i have updated the simulation to follow that logic
mhmd-azeez
force-pushed
the
fix-simulation
branch
from
8221781 to
30d4260
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes my wordpress servlet pass the simulation