Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Makefile was missing npm install step #49

Conversation

chrisdickinson
Copy link

@chrisdickinson chrisdickinson commented Jan 27, 2025

A-ha – I think the Makefile had a npm run build step, but npm doesn't automatically run install when executing npm run scripts.

@chrisdickinson chrisdickinson force-pushed the chris/20250127-just-a-test-of-the-emergency-npm-install-system branch from 4a8fee9 to f6526d0 Compare January 27, 2025 17:49
@chrisdickinson chrisdickinson changed the title wip: just a test of the emergency npm install system fix: Makefile was missing npm install step Jan 27, 2025
@chrisdickinson chrisdickinson changed the base branch from main to validate-input-schema January 27, 2025 17:51
@@ -1,4 +1,5 @@
build:
npm ci
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I used npm ci here to install all deps from the package-lock.json which is a little faster / more stable in CI situations, feel free to switch for npm i if you'd prefer!)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@chrisdickinson
Copy link
Author

chrisdickinson commented Jan 27, 2025

it looks like this commit fixed one CI issue and uncovered another:

Testing servlets/amadeus-flight-api/
🔨 Building describe output
thread '<unnamed>' panicked at crates/core/src/globals.rs:329:26:
called `Option::unwrap()` on a `None` value
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Error: wasm error: unreachable
wasm stack trace:
	.$1364(i32,i32,i32,i32,i32)
	.$1497(i32,i32)
	.$1488(i32,i32,i32)
	.$1514(i32)
	.$72(i32,i32,i32)
	.$88(i32,i32,i64,i64,i32,i32,i32) i64
	.$369(i32,i64,i64,i32,i32,i32) i64
	.$479(i32,i64,i64,i64,i32,i32,i32) i64
	.$471(i32,i64,i64,i32,i32,i32) i64
	.$479(i32,i64,i64,i64,i32,i32,i32) i64
	.$479(i32,i64,i64,i64,i32,i32,i32) i64
	.$479(i32,i64,i64,i64,i32,i32,i32) i64
	.$479(i32,i64,i64,i64,i32,i32,i32) i64
	.$479(i32,i64,i64,i64,i32,i32,i32) i64
	.$202(i32,i32,i32)
	.$1568(i32) i32
	.$1585() i32

@mhmd-azeez
Copy link
Contributor

Thanks! I will merge this and then fix the amadeus build

@mhmd-azeez mhmd-azeez merged commit b47ae02 into validate-input-schema Jan 27, 2025
1 check failed
@mhmd-azeez mhmd-azeez deleted the chris/20250127-just-a-test-of-the-emergency-npm-install-system branch January 27, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants