Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(js): add decode_error api #1007

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat(js): add decode_error api #1007

wants to merge 2 commits into from

Conversation

matteo-cristino
Copy link
Collaborator

  • chore: add yarn to mise tools list
  • feat(js): add decode_error api

@matteo-cristino matteo-cristino linked an issue Jan 19, 2025 that may be closed by this pull request
New js utility API for decoding error #974
Open
@matteo-cristino
feat(js): add decode_error api
77335a9 
parse the logs and extract all lines that start with a `[!]` both in tha main error array and in the encoded trace
@matteo-cristino
chore: add ninja to mise tools list
bfd18dc
@jaromil jaromil requested a review from puria January 21, 2025 09:12
@matteo-cristino
Copy link
Collaborator Author

add test with emoji!

puria
puria requested changes Jan 21, 2025
View reviewed changes
Copy link
Member

@puria puria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please double check with a test that holds utf-8 in the string, then it's okay for me <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puria puria puria requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New js utility API for decoding error
2 participants
@matteo-cristino @puria