WiFi and Ethernet - config static IP auto gw,mask,dns as in Arduino libs #1862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAndrassy
force-pushed
the
net_config_auto
branch
from
258fa81 to
3e02ae4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'config' functions with not all parameters specified should use default values for gw IP, subnet mask and DNS server IP. The first Arduino Ethernet library has this (with begin), I guess the first Arduino WiFi library had it too, but the default values were implemented in the firmware. Then WiFi101 and WiFiNINA are written base on WiFi lib's source code, but without the defaults implemented in firmware. (My PR are waiting to fix that.) The new WiFiS3 and WiFiC3 libraries by Arduino have it right.
This PR adds the default values for gateway, subnet mask and DNS. The solution in LwipIntfDev is the same as in ESP8266 core. And the WiFi library now redirects all versions of
configto LwipIntfDev.Tested with Pico W and W5500