Update versions of node and workflow items in GitHub Actions #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Parts of this update is needed because of actions/runner-images#10636 - the main branch is failing because of running build and test on latest ubuntu. |
The UART fails to open test was looking for a `0` in the error message, corresponding to the port number that was being opened. However, depending on the specific machine run on, the actual error from the backend may vary. On GitHub actions instead of referring to the port number it says: "error on socket connection\n - AggregateError" And on my local machine it shows "error on socket connection\n - Error: connect ECONNREFUSED 127.0.0.1" With this change we still require the adapter to report an error on socket connection, but the specific error details are not required to match any particular pattern.
jonahgraham
force-pushed
the
versions
branch
3 times, most recently
from
f8879be to
c92ddde
Compare
…ing port We were parsing the port number from gdbserver before it had been fully output. Use a regex now to wait for terminating newline so we know gdbserver has output full port.
jonahgraham
force-pushed
the
versions
branch
from
c92ddde to
9272451
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change also includes some test changes that are as a result of the changes in versions of tools.