Add supportsEvaluateForHovers #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a slight concern of turning this on for GDB as it is documented with this [requirement](https://microsoft.github.io/debug-adapter-protocol/specification#Types_Capabilities): > The debug adapter supports a (side effect free) `evaluate` > request for data hovers. Because of side-effects on read that is present in memory mapped registers in embedded systems this can cause unexpected reads of the target's registers. For Eclipse CDT I don't think there is any special code, so I think it is ok to do this here too. GDB also has a number of settings that may be useful to prevent accidental reads too. Fixes eclipse-cdt-cloud/cdt-gdb-vscode#121
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a slight concern of turning this on for GDB as it is documented with this requirement:
Because of side-effects on read that is present in memory mapped registers in embedded systems this can cause unexpected reads of the target's registers. For Eclipse CDT I don't think there is any special code, so I think it is ok to do this here too. GDB also has a number of settings that may be useful to prevent accidental reads too.
Fixes eclipse-cdt-cloud/cdt-gdb-vscode#121