-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cmake]: Fix usage after install when built with BUILD_SHARED_LIBS=ON
#2016
[cmake]: Fix usage after install when built with BUILD_SHARED_LIBS=ON
#2016
Conversation
ecal-utils is used by other exported libraries (eg: ecalhdf5) which may be static or shared so there is no need to constrain ecal-utils, it should be consistent with other libraries
ThreadingUtils is only used internally by applications so it can be static and not exported/installed
Both are only used by executables and aren't exported so they can be forced static
It is only used in applications and monitor plugins so it can be static
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not happy with hiding the Windows signing issues. It's not a mandatory action and we can merge with the sign job failing, but I would rather have it notify me of failures than report OK despite not working.
Edit: or is it just about (not) signing from forks? I am struggeling with the script.
Yeah, the change should only affect forks. The problem is my runs don't have access to your secrets so the The other option is to do something with GitHub environments and pull_request_target: https://github.com/orgs/community/discussions/50161#discussioncomment-5824158 Alternatively, if you don't like the deployment spam you'd get with that approach, could do something directly with From what I can tell, the workflow will correctly fail if something other than the secrets being unavailable goes wrong, and when the signing is skipped only the "unsigned-setup" artifact will be uploaded. Seems fine to me, but if you want me to drop the change just say and I'll open an issue to capture this. (Also, sorry for shoehorning the change in, it wasn't really necessary and obviously could have been done separately...) |
Description
Fixes the build such that the installed result is usable when eCAL is built with
BUILD_SHARED_LIBS=ON
.tcp_pubsub
submodule is now always built statically as it is a strictly internal dependency.ecal-utils
may now be static or shared depending onBUILD_SHARED_LIBS
EcalParser, QEcalParser, CustomQt, and ThreadingUtils
are now always static because they were implementation details for applications and application plugins and were not required to be installed.Related issues
Fixes #2014
Cherry-pick to