Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tycho to 4.0.8 #1733

Closed
wants to merge 0 commits into from
Closed

Update tycho to 4.0.8 #1733

wants to merge 0 commits into from

Conversation

akurtakov
Copy link
Contributor

No description provided.

@akurtakov akurtakov self-assigned this Apr 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024 •
edited
Loading

Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit fbcd01f.

♻️ This comment has been updated with latest results.

@akurtakov akurtakov force-pushed the master branch 2 times, most recently from c971827 to e8049f4 Compare April 9, 2024 08:43
@HannesWell
Copy link
Contributor

All these test-failures happen also in the attempt to update to Tycho 4.0.6: #1688

I haven't investigated it yet, maybe @laeubi can tell?

@HannesWell HannesWell mentioned this pull request Apr 9, 2024
Closed
@akurtakov akurtakov force-pushed the master branch 5 times, most recently from 6fca821 to 3d61610 Compare April 11, 2024 11:22
@akurtakov akurtakov force-pushed the master branch 2 times, most recently from 18ffb1d to 8fda5f6 Compare May 10, 2024 14:05
@laeubi
Copy link
Member

laeubi commented May 18, 2024

From the buildfailure it is a problem due to classfile changes (ECJ update?)

@HannesWell
Copy link
Contributor

From the buildfailure it is a problem due to classfile changes (ECJ update?)

The update to Tycho 4.0.6 already failed in #1688 and IIRC the comparator errors were not the problem and the fixed ECJ version was removed in an attempt to resolve that failure, but it seems like it didn't fix it.
But lets fix the comparator errors first.

@HannesWell HannesWell force-pushed the master branch 3 times, most recently from e150616 to 8074444 Compare May 18, 2024 10:51
@HannesWell
Copy link
Contributor

From the buildfailure it is a problem due to classfile changes (ECJ update?)

The comparator errors are resolved and now we (again) have the 500 test-failures.

@laeubi
Copy link
Member

laeubi commented May 18, 2024

As they all fail the same way maybe some change in P2 causing this, I would try to add a direct dependency in the test plugin to make sure its not caused by some indirect dependency missing now.

@HannesWell
Copy link
Contributor

As they all fail the same way maybe some change in P2 causing this, I would try to add a direct dependency in the test plugin to make sure its not caused by some indirect dependency missing now.

The plugin org.eclipse.m2e.tests already requires the bundle org.eclipse.m2e.maven.runtime.

@laeubi
Copy link
Member

laeubi commented May 18, 2024

As they all fail the same way maybe some change in P2 causing this, I would try to add a direct dependency in the test plugin to make sure its not caused by some indirect dependency missing now.

The plugin org.eclipse.m2e.tests already requires the bundle org.eclipse.m2e.maven.runtime.

The error says that the bundle org.eclipse.m2e.tests.common can not find the class...

@HannesWell
Copy link
Contributor

As they all fail the same way maybe some change in P2 causing this, I would try to add a direct dependency in the test plugin to make sure its not caused by some indirect dependency missing now.

The plugin org.eclipse.m2e.tests already requires the bundle org.eclipse.m2e.maven.runtime.

The error says that the bundle org.eclipse.m2e.tests.common can not find the class...

Right (I just read the first line and checked the test class). But even org.eclipse.m2e.tests.common already requires org.eclipse.m2e.maven.runtime.

@akurtakov akurtakov force-pushed the master branch 5 times, most recently from 31186b1 to 86d7ee3 Compare May 21, 2024 08:16
@akurtakov akurtakov force-pushed the master branch 3 times, most recently from 08020fa to b784e23 Compare May 21, 2024 14:42
@laeubi
Copy link
Member

laeubi commented Jun 1, 2024

Interestingly I get these errors locally as well with Tycho 4.0.4

@laeubi
Copy link
Member

laeubi commented Jun 3, 2024

As I can "reproduce" it here with Tycho 4.0.4 I suspect it must be some kind of classpath ordering problem, e.g that for consistency we order the dependencies differently (either Tycho or P2)...

@HannesWell HannesWell force-pushed the master branch 2 times, most recently from f019c56 to 04ae1d7 Compare August 24, 2024 17:26
@HannesWell HannesWell changed the title Update tycho to 4.0.7 Update tycho to 4.0.8 Aug 24, 2024
@HannesWell HannesWell mentioned this pull request Aug 26, 2024
Merged
@akurtakov akurtakov closed this Sep 26, 2024
@HannesWell
Copy link
Contributor

With Tycho 4.0.9 we could finally update: #1837

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@akurtakov akurtakov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akurtakov @HannesWell @laeubi