Fixed condition variable timed wait. #1560
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On doing some performance tests, I noticed that the condition variable timed wait function
Thread_wait_cond()was occasionally returning EINVAL because the timespec value given to it was not properly normalized.This fixes the normalization, and also checks that the input value of
timeout_msis greater than zero. Anything <= 0 will timeout immediately, which seems sensible, but will not attempt any (possibly erroneous) time offset math,This also updates the thread test app (test/thread.c) for current implementation of the signal types. For example, the application was testing for a counting semaphore whereas the current implementation is of a binary semaphore. Thus, fixes #1557