Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change some code to better match the tutorials #210

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Change some code to better match the tutorials #210

wants to merge 1 commit into from

Conversation

BenjaminPollak
Copy link

Change line "import geojson" to "import geojson as g" to reflect newcoder.io

Also change "f.write(geojson.dumps(geo_map))" to "f.write(g.dumps(geo_map))"

…oder.io

Also change "f.write(geojson.dumps(geo_map))" to "f.write(g.dumps(geo_map))"
@merwok
Copy link
Contributor

merwok commented Jun 27, 2016

Hi, thanks for the patch! In my opinion it would be better to not use aliases: it’s easier to understand “geojson.some_function” deep in the module rather than having to go back to imports to see what “g” is. (There is an exception for example for scientific Python code, where modules have common aliases used consistently: np for numpy, pd for pandas, etc.)

Do you think that changing the other text (from g to geojson) would be better? @econchick do you have a strong preference either way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants