-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update docs #5330
docs: update docs #5330
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe change involves a minor edit within the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range and nitpick comments (5)
site/docs/tutorials/socketio.zh-CN.md (5)
Line range hint
21-21
: Specify language for bash code block.This will improve syntax highlighting and readability in markdown renderers.
- ```bash + ```bash $ npm i egg-socket.io --save--- Line range hint `106-106`: **Convert emphasis to heading.** Using emphasis instead of a heading can affect the structure and readability of the document. ```diff - **开启插件:** + ### 开启插件:
Line range hint
123-123
: Add language specification to code block.Code blocks should specify a language to enable syntax highlighting.
- ``` + ```javascript // {app_root}/config/plugin.js exports.io = { enable: true, package: 'egg-socket.io', };--- Line range hint `617-617`: **Add alt text to image.** Images should have alternate text to improve accessibility. ```diff - ![](https://raw.githubusercontent.com/eggjs/egg/master/docs/assets/socketio-console.png) + ![Socket.IO Console Example](https://raw.githubusercontent.com/eggjs/egg/master/docs/assets/socketio-console.png)
Line range hint
472-472
: Potential sensitive information exposure detected.Ensure that any sensitive keys or tokens are removed or securely managed.
- const API_KEY = '1234567890abcdef'; // Example key, replace with your actual key + const API_KEY = process.env.API_KEY; // Use environment variables for sensitive keys
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- site/docs/tutorials/socketio.zh-CN.md (1 hunks)
Additional context used
Markdownlint
site/docs/tutorials/socketio.zh-CN.md
619-619: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
628-628: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
21-21: null (MD014, commands-show-output)
Dollar signs used before commands without showing output
222-222: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
325-325: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
406-406: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
477-477: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
593-593: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
221-221: null (MD031, blanks-around-fences)
Fenced code blocks should be surrounded by blank lines
405-405: null (MD031, blanks-around-fences)
Fenced code blocks should be surrounded by blank lines
476-476: null (MD031, blanks-around-fences)
Fenced code blocks should be surrounded by blank lines
592-592: null (MD031, blanks-around-fences)
Fenced code blocks should be surrounded by blank lines
106-106: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
123-123: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
617-617: null (MD045, no-alt-text)
Images should have alternate text (alt text)
629-629: Unused link or image reference definition: "socket.io" (MD053, link-image-reference-definitions)
Link and image reference definitions should be needed
631-631: Unused link or image reference definition: "uws" (MD053, link-image-reference-definitions)
Link and image reference definitions should be needed
Gitleaks
site/docs/tutorials/socketio.zh-CN.md
472-472: Detected a Generic API Key, potentially exposing access to various services and sensitive operations. (generic-api-key)
文档格式似乎写错了导致渲染错误:
Summary by CodeRabbit