Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sticky menu-item in TOC #126

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Add sticky menu-item in TOC #126

merged 1 commit into from
Dec 21, 2023

Conversation

sashachabin
Copy link
Member

@sashachabin sashachabin commented Dec 21, 2023

  • Made sticky menu item
  • Removed separator
  • Moved ul inside li for better a11y
Screen.Recording.2023-12-21.at.10.21.07.mov

@@ -200,14 +227,6 @@ html:has(.open) {
background-color: var(--color-bg-dark);
}

.separator {
Copy link
Member Author

@sashachabin sashachabin Dec 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we use border-bottom instead <hr>

)}
</li>
{currentPageUrl[1] && currentPageUrl[1] === url && anchorLinks.length > 0 && (
<ul className={styles.innerlinkContainerList}>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before
image

After
image

Copy link
Member

@fidlow fidlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@sashachabin sashachabin merged commit 281ac1d into main Dec 21, 2023
1 check passed
@sashachabin sashachabin deleted the feature/sticky-toc branch December 21, 2023 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants