Skip to content

Commit

Permalink
Fix series block video items for screen widths 880 - 890 (#1071)
Browse files Browse the repository at this point in the history
It was somewhat broken for those widths. One constant was also
incorrectly named, which I fixed. I also slightly increased the sizes
for large screens, because it didn't make a ton of sense to me that the
numbers were larger for small screens. All these changes should be very
small though.
  • Loading branch information
owi92 authored Jan 11, 2024
2 parents 6f7bb68 + cc066db commit cf66457
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion frontend/src/GlobalStyle.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ const CSS_RESETS = css({

// This prevents an increase in font size when changing from
// portrait to landscape orientation in iOS safari.
"-webkit-text-size-adjust": "none",
WebkitTextSizeAdjust: "none",
},

// This improves the readability of underlines in links.
Expand Down
8 changes: 4 additions & 4 deletions frontend/src/ui/Blocks/Series.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -543,9 +543,9 @@ const Videos: React.FC<ViewProps> = ({ basePath, items }) => {
});
};

const ITEM_MIN_SIZE = 240;
const ITEM_MIN_SIZE_LARGE_SCREENS = 260;
const ITEM_MAX_SIZE = 315;
const ITEM_MIN_SIZE = 250;
const ITEM_MIN_SIZE_SMALL_SCREENS = 240;
const ITEM_MAX_SIZE = 330;
const ITEM_MAX_SIZE_SMALL_SCREENS = 360;

const GalleryView: React.FC<ViewProps> = ({ basePath, items }) => (
Expand Down Expand Up @@ -618,7 +618,7 @@ const GalleryView: React.FC<ViewProps> = ({ basePath, items }) => (
columnGap: 12,
rowGap: 28,
[screenWidthAtMost(1600)]: {
gridTemplateColumns: `repeat(auto-fill, minmax(${ITEM_MIN_SIZE_LARGE_SCREENS}px, 1fr))`,
gridTemplateColumns: `repeat(auto-fill, minmax(${ITEM_MIN_SIZE_SMALL_SCREENS}px, 1fr))`,
},
}}>
{items.map(({ event, active }) => (
Expand Down

0 comments on commit cf66457

Please sign in to comment.