-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs with general info about Tobira #935
Add docs with general info about Tobira #935
Conversation
@LukasKalbertodt: Here some suggestions on how to formulate the general informations. In a word file with track change, since I am not that familiar with github-files. I hope that works for you. Let me know, what you think. |
Given there's a lot of edits already, I'm not going to use David's DOCX. Instead, a couple of comments:
|
As a meta comment: I think we are not really clear about the target audience of this document. Is it people involved in development to communicate precisely? Is it a specification of how Tobira behaves? Is it a manual for users? ...? We should probably decide that before discussing anything else. The rest of my comment will now discuss something else. I pushed a new version. This incooperates most of David's suggestions, with exception of the last part ("unlisted" and stuff). I wanted to wait with this until we reach consensus on all other things. Some remarks to your suggestions:
Well, technically, only part of the page tree is shown on the left side. And the navigation can show other stuff, depending on the site you are on.
I'm not sure if it's really worth explaining those in more detail here. Your descriptions for text and series blocks are also pretty... hollow, not adding any information.
But yeah, I think it's a pretty tricky situation. "Pages" is such a general term. So using that word for the editable "pages" (as described) specifically, is problematic. In our code, we use "realm" as you might know, to avoid that ambiguity. But we didn't think that was an appropriate term to use in the UI. It might be a bit late to change "page" as term for these things, but if you have any good suggestions... please!
Mhhh, we often called it "management area", right?
I don't understand: the user page section includes a couple of example URLs. Well, it includes the paths, without the
That's a good idea! Will do. |
Some thoughts to your last commit and comment:
|
The term "page" is too generic.
b7ec92c
to
e31c4ca
Compare
I added 3 commits. Most interestingly:
I think I simply missed that in your suggestions. I did not omit it on purpose. Fixed now. |
For ease of reviewing: |
Finally... this looks good in general. But I have to come back to one of my original comments:
These are now "Videos in context" and they appear under "Routes", correct? Which I don't think is adequate. I think they deserve a chapter of their own (after "Content Pages") and a better name. Mainly because they will be like 95% of the pages in a custom video portal. Or am I missing something (looking at the PDF mainly)? |
I just added a short video page chapter. I hope this should clarify things. Let me know what you think Olaf. Here you can see what exactly I changed, and here is the rendered PDF version: |
All good, thanks - even if that "short ... page" still underrepresents the quantity of video pages! Two comments:
|
Good points.
I removed that sentence completely and by simply changing the previous sentence. I think it is clearer now. Latest changes and the rendered new version: Semantics and definitions _ Tobira documentation2.pdf. |
+1 for merging |
Then lets just do it! |
I wrote this a few months ago and never got around to creating a PR.
I'm unsure about this in two ways:
I'm not sure if I have explained these things sufficiently good. Maybe my explanation is confusing, too technical, or maybe even too long?
I'm not sure if this kind of information should be in our docs. My intention for it was that we have well defined terms for our future discussions.
What do you think? Als interested in the opinion of @oas777 and @dagraf. As this is just a documentation pull request, you can click the "files changed" tab to see what documentation I suggest adding.