-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix paella dual stream layout #985
Conversation
"The "fullscreen" and "swap" icons somehow changed. Huh?" This is part of the Paella confusion: These are the icons of P7 delivered with the latest Opencast, cf. https://stable.opencast.org/paella7/ui/watch.html?id=ID-dual-stream-demo Not to be confused with P7 from https://paellaplayer.upv.es/. Or https://polimediaupv.github.io/paella-ethz/?id=belmar_16_9_hls, which has the latest and greatest design. Or is it https://polimediaupv.github.io/paella-skins/? |
@oas777 Yeah I was mostly wondering what's happening "under the hood" there. But if the new icons are the ones you prefer, at least that side effect is a good one, I suppose. |
If by "new icons" you mean the ones at https://tobira.opencast.org/events/opencast/2018/vienna/v/P7ha7_AnBU4: No, that's not a good side effect. The ones at https://polimediaupv.github.io/paella-ethz/?id=belmar_16_9_hls or https://polimediaupv.github.io/paella-skins/ are the ones we want. |
Well no, those are the old ones, also from my perspective. I'm sorry if I didn't convey that correctly. I know that these () are the ones you want, I was just making an offhand comment. |
That should certainly be fixed before we merge this. I looked into it a bit and found out a few things that might help you:
|
f2bb39e
to
ed0254b
Compare
So there is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Man how did I miss this.
Hey, so did I :D And I spend quite some time looking through the docs.
So yeah, seems to work, nice! And the space usage is absolutely improved, another UX win. Regarding the icons: I also don't know why this change causes the icons to change, but since we want these new icons, it's a win. So let's just merge.
Closes #956
Before:
After:
Two unexpected sideeffects:The "fullscreen" and "swap" icons somehow changed. Huh?this is desired and simply part of the dynamic layout it appears. Well it can be configured as I understand, but these seem to be the default.Default layout is now "Presenter" for some reason. Which is unfortunate. With this, users might think dual stream isn't working. There must be a way to configure that but I couldn't find it yet.