Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Incorporate electron/asar per-file unpack flag to bypass pattern is too long minimatch limitation [DO NOT MERGE] #120

Closed
wants to merge 2 commits into from

Conversation

mmaietta
Copy link
Contributor

@mmaietta mmaietta commented Feb 7, 2025

[DO NOT MERGE]

Depends on electron/asar#350

Resolves: #117

Notes:

  • Temporarily adds custom branch corresponding to open electron/asar PR. (this is so that CI tests can run based on the new electron/asar feature)
  • Adding generateOrderingConfig and unit test for generating an ordering file that contains an explicit unpack flag per file

Open Question

  • Does asar.listPackage respect/retain the asar ordering in its output? Or do I need to manually parse the Asar Header for ordering?

…rateOrderingConfig` and unit test for generating an ordering file that contains explicit unpack flag per file
@mmaietta mmaietta closed this Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pattern is too long minimatch error during electron/universal auto-detect unpack logic
1 participant