Also run linting across PHP versions

elifesciences/issues#9034
elifesciences · Dec 12, 2024 · 506f81b · 506f81b
1 parent bb64d7b
commit 506f81b
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -23,3 +23,14 @@ jobs:
       - name: Run tests
         run: make PHP_VERSION=${{ matrix.php_version }} test-ci
 
+  linting:
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        php_version: ["7.1", "7.2", "7.3", "7.4", "8.0", "8.1", "8.2", "8.3"]
+    steps:
+      - uses: actions/checkout@v4
+      - name: Run linting
+        run: make PHP_VERSION=${{ matrix.php_version }} lint-ci
+
diff --git a/Makefile b/Makefile
@@ -20,5 +20,9 @@ build:
 	$(if $(PHP_VERSION),,$(error PHP_VERSION make variable needs to be set))
 	docker buildx build --build-arg=PHP_VERSION=$(PHP_VERSION) -t $(PROJECT_NAME):$(PHP_VERSION) .
 
+lint-ci: build
+	docker run --rm $(PROJECT_NAME):$(PHP_VERSION) bash -c 'vendor/bin/phpcs --standard=phpcs.xml.dist --warning-severity=0 -p bin src tests'
+	docker run --rm $(PROJECT_NAME):$(PHP_VERSION) bash -c 'find src tests -name '*.php' | xargs -L1 php -l'
+
 test-ci: build
 	docker run --rm $(PROJECT_NAME):$(PHP_VERSION) bash -c 'vendor/bin/phpunit'