-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mute error occurrences #130
base: main
Are you sure you want to change the base?
Conversation
|
||
refute_receive {:telemetry_event, [:error_tracker, :error, :new], _, | ||
%{occurrence: %Occurrence{}}}, | ||
refute_receive {:telemetry_event, [:error_tracker, :error, :new], _, %{error: %Error{}}}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was wrong. We were checking the telemetry event incorrectly and it did never match because it has an %Error{}
instead of an %Occurrence{}
.
The reason is that every time we raised the error in a different line, so they were different errors and not the same.
The new code ensures that the same error is raised multiple times and helped me catch this error.
This pull request adds a new
muted
field to errors. Noisy errors can be muted in the UI so they won't send telemetry events for new occurrences.In the end I decided to use the mute instead of silence as I think that mute and unmute are fairly commonly understood terms.
This is an addition to the capability of ignoring errors that we already have, and enables the possibility of tracking error occurrences but don't notify them. Closes #117
New mute action in the error detail page:
![New mute action in the error detail page](https://private-user-images.githubusercontent.com/2965623/413523163-11663fcc-e233-4746-b5c2-a8fa7e233e3a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2MjE5NDAsIm5iZiI6MTczOTYyMTY0MCwicGF0aCI6Ii8yOTY1NjIzLzQxMzUyMzE2My0xMTY2M2ZjYy1lMjMzLTQ3NDYtYjVjMi1hOGZhN2UyMzNlM2EucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTVUMTIxNDAwWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MDk1MTM2YjRjZGExNjg0YjczZjRlNzdjNTQxMGJiNGVkM2MyODdmNmRmMGMwNmY3NmY0NjI4ZWJiZDBiYmI1NSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.2PEPXKYh9iruEt9VRWIjUHiEns0nx5IXhu1b-eYP8QQ)
Mute and unmute actions in the dashboard page
![Mute and unmute actions in the dashboard page](https://private-user-images.githubusercontent.com/2965623/413523437-182f9add-e72c-44aa-9e6f-3769b4f88f71.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2MjE5NDAsIm5iZiI6MTczOTYyMTY0MCwicGF0aCI6Ii8yOTY1NjIzLzQxMzUyMzQzNy0xODJmOWFkZC1lNzJjLTQ0YWEtOWU2Zi0zNzY5YjRmODhmNzEucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTVUMTIxNDAwWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NjNkZjc5MmQ4NDM3ZDdlMDA1NjcyY2FiYTc1YjZlYjViMzVhMDNlM2M4NTczMzAxMzA2Mzg4NGZjZjI3ZGZmZSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.H-MizMJBzUaDOzZXlL5C6M_xvFy_MsX1xHcWeRiHrp8)