Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mute error occurrences #130

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Mute error occurrences #130

wants to merge 11 commits into from

Conversation

crbelaus
Copy link
Contributor

@crbelaus crbelaus commented Feb 14, 2025

This pull request adds a new muted field to errors. Noisy errors can be muted in the UI so they won't send telemetry events for new occurrences.

In the end I decided to use the mute instead of silence as I think that mute and unmute are fairly commonly understood terms.

This is an addition to the capability of ignoring errors that we already have, and enables the possibility of tracking error occurrences but don't notify them. Closes #117

New mute action in the error detail page:
New mute action in the error detail page

Mute and unmute actions in the dashboard page
Mute and unmute actions in the dashboard page


refute_receive {:telemetry_event, [:error_tracker, :error, :new], _,
%{occurrence: %Occurrence{}}},
refute_receive {:telemetry_event, [:error_tracker, :error, :new], _, %{error: %Error{}}},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was wrong. We were checking the telemetry event incorrectly and it did never match because it has an %Error{} instead of an %Occurrence{}.

The reason is that every time we raised the error in a different line, so they were different errors and not the same.

The new code ensures that the same error is raised multiple times and helped me catch this error.

@crbelaus crbelaus changed the title Mute errors Mute error occurrences Feb 15, 2025
@crbelaus crbelaus marked this pull request as ready for review February 15, 2025 07:36
@crbelaus crbelaus requested a review from odarriba February 15, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature suggestion: ignore certain errors
1 participant