-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore Errors #79
Ignore Errors #79
Conversation
47a1b91
to
bd34eb0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to rework the condition in which the error is stored, as by default without ignorer configured they are not stored.
Also, as the last commit was a docs one, the CI didn't run but some tests should fail as it is now as errors are not stored.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
This change adds a new global flag named `:enabled` that allows to disable the error tracking on certain environments. This behaviour can be done also with a custom ignorer using the changes that we will introduce in #79 , but I felt like this use case will be quite common in dev environments and having a fast way to just disable every error is useful. Test have been added and documentation updated. Closes #81
e51959a
to
f671cc6
Compare
This pull request adds the new
ErrorTracker.Ignorer
behaviour that can be used by clients to ignore errors based on their attributes and context.I've added a test to verify that it works as expected and also updated the docs and getting started guide.