Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Errors #79

Merged
merged 5 commits into from
Sep 8, 2024
Merged

Ignore Errors #79

merged 5 commits into from
Sep 8, 2024

Conversation

crbelaus
Copy link
Contributor

@crbelaus crbelaus commented Sep 2, 2024

This pull request adds the new ErrorTracker.Ignorer behaviour that can be used by clients to ignore errors based on their attributes and context.

I've added a test to verify that it works as expected and also updated the docs and getting started guide.

@crbelaus crbelaus changed the base branch from 64-prune-resolved-errors to main September 2, 2024 15:08
@crbelaus crbelaus self-assigned this Sep 2, 2024
@crbelaus crbelaus requested a review from odarriba September 2, 2024 15:10
@crbelaus crbelaus marked this pull request as ready for review September 2, 2024 15:11
Copy link
Contributor

@odarriba odarriba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to rework the condition in which the error is stored, as by default without ignorer configured they are not stored.

Also, as the last commit was a docs one, the CI didn't run but some tests should fail as it is now as errors are not stored.

Copy link
Contributor

@odarriba odarriba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

crbelaus pushed a commit that referenced this pull request Sep 8, 2024
This change adds a new global flag named `:enabled` that allows to
disable the error tracking on certain environments.

This behaviour can be done also with a custom ignorer using the changes
that we will introduce in #79 , but I felt like this use case will be
quite common in dev environments and having a fast way to just disable
every error is useful.

Test have been added and documentation updated.

Closes #81
@crbelaus crbelaus merged commit 48e6b63 into main Sep 8, 2024
3 checks passed
@crbelaus crbelaus deleted the ignore-errors branch September 8, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants