Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add socket path to scope["server"] #2561

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Kludex
Copy link
Member

@Kludex Kludex commented Jan 12, 2025

I think we can refactor a bit what is here, but this should solve #2559.

@nggit
Copy link

nggit commented Jan 12, 2025

I haven't tried it yet but those seem like the right changes, which are safe to do without much refactoring.

Only minor (subjective):

  • /tmp is global and it's better to use a unique prefix for files like uvicorn- or uvicorn/, otherwise create test.sock in the current directory - Edit: But that's okay, if MockSocket thing doesn't create a real file
  • if rather than elif.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants