twi: add support for USCB_1 module on devices that support it #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By just uncommenting the "//#define USE_USCI_B1 1" line, you are able to use the USCI_B1 module, instead of USCI_B0. There are also some general I2C improvements, like following the order suggested in MSP430 Family Guide on how to init I2C. And avoiding setting stuff in "two_readFrom" and "twi_writeTo" that has already been set in the "init" method. There is still need for improvements before the code can be merged. Ideally, I want to be able to use both modules B0 and B1 from my sketch, so the Wire/twi needs to support having both modules in use at the same time.
|
Note that I've ripped out a part previously part of this change, and made pull request #397 for that, since it is not unique to the "USCB_1" module. |
|
I've made a simpler pull request, #590, which allows one to choose which module to use, but does not allow one to use both modules at the same time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial pull request, I think a full review and some discussions needs to take place before this can be merged, but I want to get the "process" started.
There are some major restructuring, plus I have made some changes to how the "UCBxCTL1" and "UCBxCTL0" are initialized, therefore you will see some commented out lines related to those, to make you extra aware of those changes.
The include part in Wire.cpp I also need some help on, a bit unsure how it shold be, as you can see, I have just commented it out now, but it works in my example.
You can also see that I've removed some hardware serial from usci_isr_handler.*, it does not seem to be needed, but I have not tested this, I've just seen that it compiles. If you want to do that change, maybe it should be a separate pull request ?