Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pair.to Meta.Type . qualified_name fix #12214

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Feb 1, 2025

Pull Request Description

  • looks like Reducing helper methods in Standard.Base.Meta #12031 changed Meta behavior for qualified names
  • Pair.to Meta.Type . qualified_name is returning "Standard.Base.Data.Pair.Pair.type".
  • Meta.get_qualified_type_name Pair used to return "Standard.Base.Data.Pair.Pair".
  • returning the previous behavior
  • fixing it with a Meta_Spec test
  • adjusting MetaObjectTest to the new behavior

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • All code follows the
    Java,
  • Unit tests have been written where possible.

@JaroslavTulach JaroslavTulach added the CI: No changelog needed Do not require a changelog entry for this PR. label Feb 1, 2025
@JaroslavTulach JaroslavTulach self-assigned this Feb 1, 2025
@jdunkerley jdunkerley removed the CI: Keep up to date Automatically update this PR to the latest develop. label Feb 3, 2025
@JaroslavTulach JaroslavTulach merged commit dcb8957 into develop Feb 3, 2025
47 of 50 checks passed
@JaroslavTulach JaroslavTulach deleted the wip/jtulach/PairToMetaType branch February 3, 2025 13:57
@enso-bot
Copy link

enso-bot bot commented Feb 4, 2025

Jaroslav Tulach reports a new STANDUP for yesterday (2025-02-03):

Progress: .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants