Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix benchmark comparison in bench_download.py tool #12234

Merged
merged 4 commits into from
Feb 5, 2025

Conversation

Akirathan
Copy link
Member

@Akirathan Akirathan commented Feb 5, 2025

Pull Request Description

./bench_download.py tool stopped working after #12226. Because the artifacts on benchmark workflow runs were renamed. This PR just renames the artifacts (suggested in #12201 (comment)) and also adds some unit tests.

In many unit tests, I had to bump the date of the fetched data, because GH seems to delete workflow runs that are older than 2 years.

Note that yesterday, Benchmark Upload workflow started printing a warning that there is an unknown artifact name

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@Akirathan Akirathan added the CI: No changelog needed Do not require a changelog entry for this PR. label Feb 5, 2025
@Akirathan Akirathan self-assigned this Feb 5, 2025
@Akirathan Akirathan changed the title Wip/akirathan/bench artifact names changed Fix benchmark comparison in bench_download.py tool Feb 5, 2025
@Akirathan
Copy link
Member Author

Akirathan commented Feb 5, 2025

Manually scheduled https://github.com/enso-org/enso/actions/runs/13156491997/job/36714698889 finished successfully, and uploaded even the new artifacts as data. We are ready to merge.

GitHub
Enso Analytics is a self-service data prep and analysis platform designed for data teams. - Benchmarks upload · 428526c

@Akirathan Akirathan added the CI: Ready to merge This PR is eligible for automatic merge label Feb 5, 2025
@mergify mergify bot merged commit 10fe252 into develop Feb 5, 2025
26 checks passed
@mergify mergify bot deleted the wip/akirathan/bench-artifact-names-changed branch February 5, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants