Enable ydoc-server tests #12252
Enable ydoc-server tests #12252
Conversation
4e6
added
CI: No changelog needed
|
IDK Windows build seems working 🤷 |
4e6
requested review from
JaroslavTulach,
hubertp and
Akirathan
as code owners
There was a problem hiding this comment.
- I am glad
sbtdoesn't requirenode& co. right now- when the dependency on
nodewas introduced many of my build machines stopped buildingsbt buildEngineDistribution - the
sbtbuild is more lightweight withoutnode& co.
- when the dependency on
- it is bad we don't execute
ydoc-serverintegration tests at all, but- we don't use
ydoc-serveranywhere in the release right now - until work on
Ydoc.jsis resuscitated... - we just want to make sure, it continues to work
- and it doesn't regress
- we don't use
As such, I suggest to
- not enable
ydoc-serverfor development at all - only execute
ydoc-server/teston CI
I believe following patch:
enso/build_tools$ git diff
diff --git build_tools/build/src/engine/context.rs build_tools/build/src/engine/context.rs
index eb1296f548..bbb8278f62 100644
--- build_tools/build/src/engine/context.rs
+++ build_tools/build/src/engine/context.rs
@@ -305,6 +305,7 @@ impl RunContext {
}
if self.config.build_native_ydoc {
tasks.push("ydoc-server/buildNativeImage");
+ tasks.push("ydoc-server/test");
}
if self.config.build_project_manager_package() {
tasks.push("buildProjectManagerDistribution");would be a great balance in achieving so:
- the
ydoc-serverwould remain tested with every commit - regular
sbtusage wouldn't requirenode& co. - Dmitry (or anyone else working on Ydoc.js) could still use
sbt ydoc-server/testlocally
As such I am not approving this change, but feel free to proceed if you think it is better than my suggested solution.
|
It's not only that. Not having |
There was a problem hiding this comment.
If the CI is happy, I am OK with this change.
when the dependency on node was introduced many of my build machines stopped building sbt buildEngineDistribution.
That is because buildEngineDistribution depends on ydoc-server/compile. That can be removed, and at the same time, ydoc-server can be kept in the enso aggregate so that its tests and global commands like javafmtCheck still runs on that project but buildEngineDistribution does not run node.
not enable ydoc-server for development at all
I would keep that in the aggregate, but remove the dependency from buildEngineDistribution, if possible.
|
I am looking into the history of
|
@Akirathan |
|
@4e6 It does not currently. But it used to. I remember that, and @JaroslavTulach as well. My question is: How is that even possible? |
|
We don't start the ydoc-server as a part of the language-server anymore. You can run it as a separate process though |
That is good to know. So even if |
|
Although, I see another issue with running I'll try to see if it is SBT-related or not
|
it looks like it's just a Bazel build randomly failing |
Pull Request Description
Enable
ydoc-servertests aftercorepackis fixed in #12249Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.