Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async execution improvements #12282

Open
wants to merge 62 commits into
base: develop
Choose a base branch
from

Conversation

somebody1234
Copy link
Contributor

Pull Request Description

  • Close https://github.com/enso-org/cloud-v2/issues/1739
    • Invalidate executions periodically (every minute) to make sure they are up to date
    • Fix path for deleting project executions
    • Use ISO dates for all dates - including the date input
    • Fix not being able to edit dates
    • Add combo box for selecting timezone
    • Hide selected option in dropdown so that it does not show up twice
    • Completely hide advanced options (execution time limit, parallel mode) by default
    • Rename "X of month" to "Monthly on X"
    • Change "daily" repeat type to mean every day
    • Add "weekly" repeat type
    • Remove "hourly" repeat type
    • Show count of executions per day in calendar cells instead of list of times
    • Only show three next repeat dates, and move to end
    • ⚠️ Not yet using the new endpoint yet to fetch execution status

Important Notes

None

Testing Instructions

  • Just test the adjustments above.
  • There was a refactor done to inputs (extracting a sub-component out) to make ComboBox work so other forms (anywhere) can be tested to make sure nothing is broken

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@somebody1234 somebody1234 force-pushed the wip/sb/async-execution-improvements branch from 7730db9 to a195674 Compare February 17, 2025 09:19
@PabloBuchu
Copy link
Contributor

  1. Time selector is too close to date. can we make the input wider?
  2. datetime, timezone, repeate are not aligned. all have different width
  3. Lets hide advanced options. they do nothing right now
  4. I can write in timezone selector
  5. Can we add (GMT-XX:00) in the timezone picker?
  6. Missing isoformat for repetition
  7. Can we make some spacing around the months and remove the border
Screenshot 2025-02-18 at 09 25 28 8. Weekly should have all days selected by default

@somebody1234
Copy link
Contributor Author

Missing isoformat for repetition

should be isoformat unless i'm missing something, mind explaining what specifically is not correct?

@somebody1234
Copy link
Contributor Author

somebody1234 commented Feb 18, 2025

I can write in timezone selector

intentional - it's part of the component we use, it's used to filter the options. by default, it already shouldn't let you pick an invalid option

@PabloBuchu
Copy link
Contributor

| should be isoformat unless i'm missing something, mind explaining what specifically is not correct?
hm I jumped into conclusion that it should show 8601 but thats fine.. we can ask on demo

@somebody1234
Copy link
Contributor Author

should be ready for re-QA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants