api: sharing global ratelimit buckets #5227
Open
+23
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5227 +/- ##
==========================================
- Coverage 67.97% 67.94% -0.04%
==========================================
Files 212 212
Lines 33328 33328
==========================================
- Hits 22656 22645 -11
- Misses 9301 9309 +8
- Partials 1371 1374 +3 ☔ View full report in Codecov by Sentry. |
arkodg
reviewed
Feb 10, 2025
arkodg
reviewed
Feb 10, 2025
arkodg
reviewed
Feb 10, 2025
arkodg
reviewed
Feb 10, 2025
arkodg
reviewed
Feb 10, 2025
|
added some comments, but overall +1 with the feature the implementation will be tricky, since we cannot rely on per route based keys and descriptors, and find a way to share it, one idea is to create a key prefix in the gateway api layer and use it in the xds layer if its set |
|
/retest |
Signed-off-by: Ryan Hristovski <[email protected]>
Signed-off-by: Ryan Hristovski <[email protected]>
Signed-off-by: Ryan Hristovski <[email protected]>
Signed-off-by: Ryan Hristovski <[email protected]>
Signed-off-by: Ryan Hristovski <[email protected]>
Co-authored-by: Arko Dasgupta <[email protected]> Signed-off-by: Ryan Hristovski <[email protected]> Signed-off-by: Ryan Hristovski <[email protected]>
Co-authored-by: Arko Dasgupta <[email protected]> Signed-off-by: Ryan Hristovski <[email protected]> Signed-off-by: Ryan Hristovski <[email protected]>
Signed-off-by: Ryan Hristovski <[email protected]>
Signed-off-by: Ryan Hristovski <[email protected]>
Signed-off-by: Ryan Hristovski <[email protected]>
Signed-off-by: Ryan Hristovski <[email protected]>
Signed-off-by: Ryan Hristovski <[email protected]>
Signed-off-by: Ryan Hristovski <[email protected]>
Signed-off-by: Ryan Hristovski <[email protected]>
Signed-off-by: Ryan Hristovski <[email protected]>
* build(deps): bump github.com/envoyproxy/go-control-plane/contrib Bumps [github.com/envoyproxy/go-control-plane/contrib](https://github.com/envoyproxy/go-control-plane) from 1.32.3 to 1.32.4. - [Release notes](https://github.com/envoyproxy/go-control-plane/releases) - [Changelog](https://github.com/envoyproxy/go-control-plane/blob/main/CHANGELOG.md) - [Commits](envoyproxy/go-control-plane@envoy/v1.32.3...envoy/v1.32.4) --- updated-dependencies: - dependency-name: github.com/envoyproxy/go-control-plane/contrib dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * build(deps): bump github.com/spf13/pflag from 1.0.5 to 1.0.6 Bumps [github.com/spf13/pflag](https://github.com/spf13/pflag) from 1.0.5 to 1.0.6. - [Release notes](https://github.com/spf13/pflag/releases) - [Commits](spf13/pflag@v1.0.5...v1.0.6) --- updated-dependencies: - dependency-name: github.com/spf13/pflag dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * fix gen Signed-off-by: zirain <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: zirain <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Ryan Hristovski <[email protected]>
Signed-off-by: Ryan Hristovski <[email protected]>
ryanhristovski
force-pushed
the
feat-global-gateway-ratelimitting
branch
from
ba808e1 to
29b72b7
Compare
|
/retest |
|
@arkodg i fixed a test in this PR unrelated to my changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5194 (comment)
Currently using
shared: boolfor setting a global rate limiting rule, another option discussed wasscope: gateway/httproute.Does anyone have a strong opinion on how rate limit policies should be labeled to have a global scope?