-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add section on website modes #125
Conversation
✅ Deploy Preview for playful-gelato-7892ba ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
1afc36f
to
2dc1793
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing to resolve issue #100 @jamesmbaazam!
I've left a couple of comments within the text.
I would also prefer if this was in it's own blueprints page. I think the information added is too specific to be considered a general principle. Instead I would like if there was a dedicated page for Epiverse-TRACE package websites. For now it can be a small page, just including this information, but gives us a place to expand on things like the website theme, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for incorporating my previous requests @jamesmbaazam. I've requested a couple of minor changes in the text but overall it's looking good.
Co-authored-by: Joshua Lambert <[email protected]>
A |
Best not to introduce it, so I've removed it in d782cf3. |
This PR fixes #100 by adding a subsection under the "documentation" section to layout the rational for using the "unreleased" development mode for
pkgdown
.