Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add section on website modes #125

Merged
merged 14 commits into from
Nov 19, 2024
Merged

Add section on website modes #125

merged 14 commits into from
Nov 19, 2024

Conversation

jamesmbaazam
Copy link
Member

This PR fixes #100 by adding a subsection under the "documentation" section to layout the rational for using the "unreleased" development mode for pkgdown.

Copy link

netlify bot commented Oct 29, 2024

Deploy Preview for playful-gelato-7892ba ready!

Name Link
🔨 Latest commit d782cf3
🔍 Latest deploy log https://app.netlify.com/sites/playful-gelato-7892ba/deploys/673ca0c82a86920008433189
😎 Deploy Preview https://deploy-preview-125--playful-gelato-7892ba.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@joshwlambert joshwlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to resolve issue #100 @jamesmbaazam!

I've left a couple of comments within the text.

I would also prefer if this was in it's own blueprints page. I think the information added is too specific to be considered a general principle. Instead I would like if there was a dedicated page for Epiverse-TRACE package websites. For now it can be a small page, just including this information, but gives us a place to expand on things like the website theme, etc.

principles.qmd Outdated Show resolved Hide resolved
principles.qmd Outdated Show resolved Hide resolved
principles.qmd Outdated Show resolved Hide resolved
Copy link
Member

@joshwlambert joshwlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for incorporating my previous requests @jamesmbaazam. I've requested a couple of minor changes in the text but overall it's looking good.

website.qmd Outdated Show resolved Hide resolved
website.qmd Outdated Show resolved Hide resolved
website.qmd Outdated Show resolved Hide resolved
website.qmd Outdated Show resolved Hide resolved
website.qmd Outdated Show resolved Hide resolved
website.qmd Outdated Show resolved Hide resolved
website.qmd Outdated Show resolved Hide resolved
website.qmd Outdated Show resolved Hide resolved
@joshwlambert
Copy link
Member

A .Rproj file has been added in this PR. Not sure if this should be removed before merging.

@jamesmbaazam
Copy link
Member Author

A .Rproj file has been added in this PR. Not sure if this should be removed before merging.

Best not to introduce it, so I've removed it in d782cf3.

@jamesmbaazam jamesmbaazam merged commit 7af6e55 into main Nov 19, 2024
5 checks passed
@jamesmbaazam jamesmbaazam deleted the issue100 branch November 19, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pkgdown development mode
2 participants