Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update final function versions to main. #111

Merged
merged 15 commits into from
Feb 23, 2024
Merged

Update final function versions to main. #111

merged 15 commits into from
Feb 23, 2024

Conversation

Juanmontenegro99
Copy link
Member

All suggestions and issues created during the epimodelac course were added. In addition to correcting some bugs presented in the issues:
#84 Rewview Vignettes
#96 Endemic Channel calculations
#101 Index Moran map
#97 Population projections
#100 Ethnicity function
#69 Distance Matrix
#99 Describe occupation function and plot
#108 Visualization and grammar

Juanmontenegro99 and others added 15 commits December 6, 2023 10:34
* Fix x-axis in population_pyramid plot

* Fix x-axis in age_risk plot

* Fix total population bug in pop_pyramid

* Fix x-axis in age_risk plot total False

* Fix morans_index legend

* Fix \n bug in describe_ethnicity

* Fix lint warnings
* Warning geom_mean

geom_mean handle zero values but is important to notify the user that the input includes them

* Fix geom_mean

Improve exceptions handling and fixing error in habib's implementation

* Fix geom_mean

Fix optimization method in geom_mean

* Create geom_sd

Creation of a function to return the standard deviation of a vector according to the method used to determine the geometric mean

* Change geom_mean epsilon

Change of scale of epsilon value to reduce standard deviation of the series. However optimal epsilon value ramains to be researched.

* Fix stats::sd usage

* Change standard deviation approach

As stated in #96 standard deviation should account for transformation of data

* Update utils.R

* Styling fix

* Udpate/create documentation

* export geom_sd

* Update utils.R

* Solve issue #96

* Change stop's for stopifnot's

* Delete print of delta

* Update test-utils.R

* Update demographics.R
* Update and add legends in morans_index map

* Update colors in map

* Style and documentation

* Solve #101
* Review plots and prints in the demographics funcitons (#93)

* Fix x-axis in population_pyramid plot

* Fix x-axis in age_risk plot

* Fix total population bug in pop_pyramid

* Fix x-axis in age_risk plot total False

* Fix morans_index legend

* Fix \n bug in describe_ethnicity

* Fix lint warnings

* update population projections post COVID-19

* Fix vignette bug

* correct columns names

* Fix population_pyramid function

* Style corrections

* Fix incidence_rate bug

* Fix age_risk bug

* Update tests for the new dimensions

* Update tests for the new dimensions

* Fix global functions definition
* #100 Fix lint

* Change to message and fix order

* update test and output function
* Warning geom_mean

geom_mean handle zero values but is important to notify the user that the input includes them

* Fix geom_mean

Improve exceptions handling and fixing error in habib's implementation

* Fix geom_mean

Fix optimization method in geom_mean

* Create geom_sd

Creation of a function to return the standard deviation of a vector according to the method used to determine the geometric mean

* Change geom_mean epsilon

Change of scale of epsilon value to reduce standard deviation of the series. However optimal epsilon value ramains to be researched.

* Fix stats::sd usage

* Change standard deviation approach

As stated in #96 standard deviation should account for transformation of data

* Update utils.R

* Styling fix

* Udpate/create documentation

* export geom_sd

* Update utils.R

* Solve issue #96

* Change stop's for stopifnot's

* Delete print of delta

* Update test-utils.R

* Update demographics.R
* Update occupational_plot

* Separe describe_occupation and plot

* Style

* Enhancement in occupational plot

* Change describe_occupation function

* add gender and plot options to describe_occupation

* Fix Occupational plot and create circular plot

* First draft of circular plotting of occupations

* Unify describe_occupation and occupation_plot

* Update test fpr describe_occupation

* Update vignette for new describe_occupation function

* Update documentation

* Style

* update plot parameter occupation_plot

* Style

* update tests

* Style

* Fix igraph bug

* fix distance_matrix bug

* Add new library

* Update tests for describe_occupation

* Fix global parameters and descriptions

* Revert "Fix global parameters and descriptions"

This reverts commit 0f0d84d.

* Update function descirptions

* global variables occupation_plot

* global variable occupation_plot_2

* Add warning to occupation_plot_2

* Documentation

* Style

* Fix note in check

Replace double use of %>% by double use of subset function

---------

Co-authored-by: juan-umana <[email protected]>
* Update tables visualization

* Update table visualization

* Update paper

* Update paper

* Update functions description

* Delete unused comments

* Extends interpretation of morans_index

* Update function descriptions and grammar

* Update function descriptions and grammar

* Style

* Fix bug

* Documentation

* 85+ clarification

* Update DESCRIPTION

* Update README.md

---------

Co-authored-by: juan-umana <[email protected]>
@Juanmontenegro99 Juanmontenegro99 added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Feb 23, 2024
Copy link
Member

@juan-umana juan-umana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bugs and features reviewed and succesfully addressed in their respective issues and/or PR

@Juanmontenegro99 Juanmontenegro99 merged commit 952539c into main Feb 23, 2024
7 checks passed
@Juanmontenegro99 Juanmontenegro99 deleted the dev branch February 23, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants