Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatic scheduling of missions #2033

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Automatic scheduling of missions #2033

wants to merge 1 commit into from
+392 −4

Conversation

mrica-equinor
Copy link
Contributor

@mrica-equinor mrica-equinor commented Feb 19, 2025 •
edited
Loading

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like console.log, TODO, etc.
  • The PR has been tested locally
  • A test have been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that require new issues
  • The changes does not introduce dead code as unused imports, functions etc.

@github-actions GitHub Actions
Copy link

🔔 Changes in database folder detected 🔔
Do these changes require adding new migrations? 🤔 In that case follow these steps.
If you are uncertain, ask a database admin on the team 😄

@mrica-equinor mrica-equinor changed the title Auto achedule missions Automatic acheduling of missions Feb 19, 2025
@github-actions GitHub Actions
Copy link

🔔 Migrations changes detected 🔔
📣 Remember to comment "/UpdateDatabase" after review approval for migrations to take effect!

@github-actions github-actions bot added the database-change Will require migration label Feb 19, 2025
@mrica-equinor mrica-equinor marked this pull request as draft February 19, 2025 13:07
@mrica-equinor mrica-equinor force-pushed the auto-achedule-missions branch 2 times, most recently from 6471e5a to c063d64 Compare February 20, 2025 13:33
@mrica-equinor mrica-equinor changed the title Automatic acheduling of missions Automatic scheduling of missions Feb 20, 2025
@Eddasol Eddasol linked an issue Feb 21, 2025 that may be closed by this pull request
Add cronjob for automatically scheduling missions #2029
Open
@mrica-equinor mrica-equinor marked this pull request as ready for review February 21, 2025 14:08
@mrica-equinor
Copy link
Contributor Author

mrica-equinor commented Feb 21, 2025 •
edited
Loading

Closes #2029

mrica-equinor
mrica-equinor commented Feb 21, 2025
View reviewed changes
backend/api/Services/MissionDefinitionService.cs
@@ -26,6 +26,8 @@ public Task<List<MissionDefinition>> ReadByInspectionAreaId(
bool readOnly = true
);

public Task<List<MissionDefinition>?> ReadByHasInspectionFrequency(bool readOnly = true);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public Task<List<MissionDefinition>?> ReadByHasInspectionFrequency(bool readOnly = true);
public Task<List<MissionDefinition>?> ReadByHasAutoScheduleFrequency(bool readOnly = true);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
database-change Will require migration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add cronjob for automatically scheduling missions
1 participant
@mrica-equinor