Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused initializeParams #710

Merged
merged 2 commits into from
Feb 6, 2025
Merged

Remove unused initializeParams #710

merged 2 commits into from
Feb 6, 2025

Conversation

Eddasol
Copy link
Contributor

@Eddasol Eddasol commented Feb 6, 2025

The commit "Remove unused initialize params" causes breaking-change and requires update of robot-interface in all isar-"robot" packages

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like logging, TODO, etc.
  • The PR has been tested locally
  • A test has been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that requires new issues
  • The changes do not introduce dead code as unused imports, functions etc.

@Eddasol Eddasol added the breaking-change A breaking change which introduces changes to the public APIs label Feb 6, 2025
@Eddasol Eddasol self-assigned this Feb 6, 2025
This was referenced Feb 6, 2025
Merged
Merged
@Eddasol Eddasol force-pushed the remove-localize branch 2 times, most recently from 08d473d to bdd7ab6 Compare February 6, 2025 11:10
@Eddasol Eddasol marked this pull request as ready for review February 6, 2025 11:12
@Eddasol Eddasol changed the title Remove localize Remove unused initializeParams Feb 6, 2025
@Eddasol Eddasol merged commit 176568f into equinor:main Feb 6, 2025
7 checks passed
@Eddasol Eddasol deleted the remove-localize branch February 6, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeshub aeshub aeshub approved these changes

Assignees

@Eddasol Eddasol

Labels
breaking-change A breaking change which introduces changes to the public APIs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eddasol @aeshub