Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

72397 bug/72397 library framework should support url that will bring up the page #815

Merged
merged 6 commits into from
Apr 25, 2024
Merged

72397 bug/72397 library framework should support url that will bring up the page #815

merged 6 commits into from
Apr 25, 2024

Conversation

kslazykv
Copy link
Contributor

@kslazykv kslazykv commented Mar 20, 2024 •
edited by azure-boards bot
Loading

@kslazykv kslazykv requested a review from VRiveland March 20, 2024 20:32
@github-actions github-actions bot added invitation for punchout Changes to the IPO module missing test There doesnt seem to be a test associated with this plantConfig Changes to the plantconfig module labels Mar 20, 2024
@kslazykv kslazykv requested a review from chormaz March 25, 2024 08:40
@chormaz
Copy link
Contributor

chormaz commented Mar 25, 2024

Seems to work - but a couple of comments:

image

Links in the treeview should be the same color as other links (i.e. not blue)

When I right-click on an item in the list and select open in new tab, it displays the correct item. However, the treeview is not expanded to the selected item.
image

chormaz
chormaz suggested changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@chormaz chormaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment in PR

@kslazykv kslazykv merged commit 2de97b8 into master Apr 25, 2024
8 checks passed
@kslazykv kslazykv deleted the bug/72397-Library-framework-should-support-url-that-will-bring-up-the-page branch April 25, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chormaz chormaz chormaz requested changes

@larskay larskay larskay approved these changes

@VRiveland VRiveland Awaiting requested review from VRiveland

Assignees
No one assigned
Labels
invitation for punchout Changes to the IPO module missing test There doesnt seem to be a test associated with this plantConfig Changes to the plantconfig module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kslazykv @chormaz @larskay