Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Update logging system to use format included in C++ standard #449

Open
jopadan opened this issue Feb 15, 2025 · 1 comment

Comments

@jopadan
Copy link

jopadan commented Feb 15, 2025

std::format
std::formatter<std::filesystem::path>

  • remove 3rdparty/fmt and GTest
  • adapt the code to use format version included in C++ standard
#include <filesystem>
#include <format>
namespace logging
{
/* adapt code here */
};
@ericwa
Copy link
Owner

ericwa commented Feb 19, 2025

  • we use the fmt::color:: terminal color features in fmt so that would need a replacement
  • time to compile the C++ code is a priority for us, and the std::format has worse compile times than libfmt when I've tried. We also use it in practically every source file so small improvements add up here.
  • Not bundling GTest is possible, but then how do we obtain it for CI? For devs on Windows? (vcpkg I guess is the obvious way.)

if you're wanting to avoid bundled libs, we could avoid downloading GTest if DISABLE_TESTS is set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants