Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GNUInstallDirs and BINDIR/DOCDIR updates #447

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jopadan
Copy link

@jopadan jopadan commented Feb 14, 2025

  • Add include(GNUInstallDirs) and use ${CMAKE_INSTALL_BINDIR} or ${CMAKE_INSTALL_DOCDIR}
  • Update .gitignores with source tree build garbage allowing git add -A, git commit -a and cmake . --install-prefix=/usr
  • Skip TBB and embree install by default
  • Remove docs/Makefile minimal Makefile

TODO

@jopadan jopadan force-pushed the main branch 3 times, most recently from 41f72af to 397801f Compare February 14, 2025 20:19
@jopadan jopadan force-pushed the main branch 7 times, most recently from 9fefcb8 to 397801f Compare February 18, 2025 18:23
@ericwa
Copy link
Owner

ericwa commented Feb 19, 2025

So to summarize, the goal here is to make make install usable on Linux etc. systems, and it's currently not?

This sounds good, thanks. It's going to break our current GitHub Actions packaging though.

  • We'll need a cmake option() for using ${CMAKE_INSTALL_BINDIR} / ${CMAKE_INSTALL_DOCDIR} instead of . as it was previously. Maybe something like EWT_USE_GNU_INSTALL_DIRS. It can default to YES but the CI scripts (build-*.sh/ps1) will need to pass NO.
  • The CI scripts will need to pass -DSKIP_TBB_INSTALL=NO -DSKIP_EMBREE_INSTALL=NO.
  • Deleting the sphinx makefile is fine
  • The .gitignore change I'm not a fan of... in-source builds are discouraged / not idiomatic CMake, so this shouldn't be necessary IMO. Can you just do an out of source build instead e.g. mkdir build && cd build && cmake ..?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants