Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix embree4 bitrot #433

Closed
wants to merge 2 commits into from
Closed

Fix embree4 bitrot #433

wants to merge 2 commits into from

Conversation

dsvensson
Copy link
Contributor

Fixes #428

@dsvensson
Copy link
Contributor Author

dsvensson commented Jul 20, 2024

...except that it also hits an embree-unrelated test failure it seems.

@ericwa
Copy link
Owner

ericwa commented Jul 20, 2024

Thanks. I'll see if I can repro the Ubuntu 24.04 + Asan error.

@ericwa
Copy link
Owner

ericwa commented Jul 21, 2024

I couldn't repro the Asan failure. However, on my local system I was using Ubuntu 24.04 (under WSL) + distro copies of TBB + Embree 4.

I checked the failing Ubuntu 24.04 CI logs, and there, it's still downloading Embree 3 + a binary package of TBB. So I'm trying adjusting that to make it use the distro copy of TBB + Embree

@ericwa
Copy link
Owner

ericwa commented Jul 21, 2024

Fixed the ASan error (it was related to a .wad in the test suite having a 16-character long texture name) and merged in 8ac82b7

Thanks!

@ericwa ericwa closed this Jul 21, 2024
@dsvensson
Copy link
Contributor Author

Oops... my bad missed what the CI used :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.0.0-alpha8 fails to build with embree4
2 participants