fix: make is-builtin-module
also support CJS + work with non-standard names
#42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues in the
is-builtin-module
codemod:It doesn't work with non-standard import names. If you imported it like this:
The codemod would replace it with:
But it wouldn't update the usages of the package, staying as
banana
. I've added a fixture undercase-2
to handle this.It doesn't work with CJS. If used with a
require
call it would simply do nothing.I've added a fixture under
case-3
to test that.Note: I'm facing an issue here, see my comment below 👇