fix: make types usable in CommonJS #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
mdjermanovic
approved these changes
Jan 13, 2025
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Similar to eslint/rewrite#143, this PR ensures that the
@eslint/jsontypes can be imported from a CommonJS module whenmoduleResolutionis one of'node16'or'nodenext'. This is currently not possible because of an issue with the types in@eslint/plugin-kitthat has been fixed in the latest versionv0.2.5.What changes did you make? (Give an overview)
@eslint/plugin-kitto version spec"^0.2.5".@eslint/corea runtime dependency of this package.@eslint/jsoncan be imported from a.ctsfile.Related Issues
refs eslint/rewrite#143.
Is there anything you'd like reviewers to focus on?