feat: add CommonJS core types
#102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fasttime
commented
Aug 9, 2024
Comment on lines
-13
to
-15
| "directories": { | ||
| "test": "tests" | ||
| }, |
There was a problem hiding this comment.
There is no "tests" directory in this package. We will want to add it at some point.
fasttime
commented
Aug 9, 2024
Comment on lines
-35
to
39
| "@types/eslint": "^9.6.0", | ||
| "eslint": "^9.0.0", | ||
| "mocha": "^10.4.0", | ||
| "typescript": "^5.4.5" |
There was a problem hiding this comment.
It looks like only the typescript dependency is used during the build (to run the tsc command). eslint is only used when linting from the root of the monorepo, where it is already included in the devDependencies.
nzakas
previously approved these changes
Aug 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Add CommonJS types to
@eslint/core.What changes did you make? (Give an overview)
I've added a build step that copies the generated
esm/types.d.tsfile tocjs/types.d.ctsin thedistdirectory. Updated settings so that bothdistfiles will be published to npm and JSR instead of the source file. This follows the pattern we are using in other packages in this repo.I've verified that the new
.ctsmodule can be imported in@types/eslintwhen@eslint/coreis added as a dependency.Related Issues
fixes #95
Is there anything you'd like reviewers to focus on?