Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make meta.replacedBy read only #146

Merged
merged 1 commit into from
Jan 29, 2025
Merged

fix: Make meta.replacedBy read only #146

merged 1 commit into from
Jan 29, 2025

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Jan 28, 2025

Prerequisites checklist

What is the purpose of this pull request?

Make compatibility changes to RuleDefinition

What changes did you make? (Give an overview)

Changed meta.replacedBy from string[] | undefined to readonly string[] | undefined to be backwards-compatible with the definitions in @types/eslint.

Related Issues

related to eslint/eslint#19157 (comment)

Is there anything you'd like reviewers to focus on?

@eslint-github-bot eslint-github-bot bot added the bug Something isn't working label Jan 28, 2025
Copy link
Member

@fasttime fasttime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fasttime fasttime merged commit 7dfc0d9 into main Jan 29, 2025
18 checks passed
@fasttime fasttime deleted the rule-def-type-update branch January 29, 2025 06:06
@github-actions github-actions bot mentioned this pull request Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted bug Something isn't working
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

2 participants